Jump to content

Sly_Ripper

Clients
  • Posts

    177
  • Joined

  • Last visited

 Content Type 

Downloads

Release Notes

IPS4 Guides

IPS4 Developer Documentation

Invision Community Blog

Development Blog

Deprecation Tracker

Providers Directory

Forums

Events

Store

Gallery

Everything posted by Sly_Ripper

  1. Using OAuth while you’re already authenticated with the forum. If 2FA is enabled, after inputting user/pass you’re just redirected to the forum index instead of triggering 2FA/redirecting to the redirect URL set in the oauth app. Disabling 2FA or logging out of the forum first both work fine.
  2. Steps to reproduce Enable/set up 2FA Log into forum Attempt to log into external app with the forum's OAuth (/oauth/authorize/?client_id=client_id_here&response_type=code&scope=scopes&prompt=login) Upon logging in you will be redirected to the forum homepage, not the correct redirect url Disabling 2FA fixes this, as does logging out of the forum first
  3. When "show on member's profile" is set to "Do not show", it will also not show on content submissions when that's set to show. The content submission setting should either apply or be disabled Edit: actually, when content submissions was set to "show to all" it was being treated as "show to staff and profile owner"
  4. Yeah this needs fixing, or at least display a message to clear the cache
  5. Allow IN_DEV with designer's mode, huge pain in the ass
  6. From what I can tell, this seems to be by design? Even deleting a forum in the admin panel has the same effect. Topics aren't considered children of a Forum, but a content item. Although there's a confirmation on deleting in the admin panel, there's no indication that all the topics will be left in limbo.
  7. It didn't appear to even create a background task
  8. Topics are orphaned despite passing 'deleteChildrenOrMove' when deleting a forum via the API, they should be moved. Not moved:
  9. [2023-07-04T16:42:25,544][INFO ][o.o.c.m.MetadataDeleteIndexService] [e14911be311d] [content/YyPDIyO8TqCQgJPetdn7UA] deleting index [2023-07-04T16:42:25,582][INFO ][o.o.a.u.d.DestinationMigrationCoordinator] [e14911be311d] Detected cluster change event for destination migration [2023-07-04T16:42:25,583][ERROR][o.o.i.i.ManagedIndexCoordinator] [e14911be311d] get managed-index failed: [.opendistro-ism-config] IndexNotFoundException[no such index [.opendistro-ism-config]] Definitely broken, tried opensearch 2.0.1 and 2.1.0. When rebuilding, the index is deleted and not re-created. Tried elasticsearch 7.17.10 and it works fine.
  10. It's a localhost dev install, the URLs are being generated like this:
  11. I considered attaching the sub-forums to clubs but forums that are part of a club are still loaded on index/forum views. An Invision install with clubs enabled are possibly prone to this slowdown, I don't know if the club rows are evaluated or not.
  12. Basically, we create a sub-forum for every PlayStation game so topics stay organised. Similar to how every game on Steam has it's own sub-forum: https://steamcommunity.com/discussions/#games
  13. Continuing from this topic: The board index (and I assume any forum listing) grabs every row from forums_forums, this could be 20k sub-forums. The board index should only grab nodes/categories with a parent ID of -1 and then any forums with those results as a parent, and sub-forums of that parent. The only reason I can think of that it's not done this way is to provide the correct "last post" info for the user's permissions. It would be nice to have an option to just limit the "last post" depth to 1 sub-forum deep and have a more performant forum.
  14. Tested on a fresh install, for some reason 'app' is being replaced with the domain
  15. I mentioned the line that throws the error in the first post, using the doc's code, '$databaseIdFields' is not being overwritten by the hook correctly. #0 /app/system/Member/Member.php(240): IPS\Patterns\_ActiveRecord::load() #1 /app/applications/appname/api/members.php(28): IPS\_Member::load() #2 /app/system/Api/Controller.php(180): IPS\appname\api\_members->GETitem() #3 /app/system/Dispatcher/Api.php(343): IPS\Api\_Controller->execute() #4 /app/api/index.php(11): IPS\Dispatcher\_Api->run() #5 {main} Doing it this way works, probably not the best idea though: class appname_hook_CustomMemberColumns extends _HOOK_CLASS_ { protected static $databaseIdFields = array('name', 'email', 'remote_id');
  16. 2 @Matt this is either a bug or bad docs
  17. array(3) { [0]=> string(4) "name" [1]=> string(5) "email" [2]=> string(9) "remote_id" } Still throws an error when trying to load a member with 'remote_id'. Being in an API route shouldn't make a difference?
  18. It's literally just a fresh hook and the example code //<?php /* To prevent PHP errors (extending class does not exist) revealing path */ if ( !\defined( '\IPS\SUITE_UNIQUE_KEY' ) ) { exit; } class appname_hook_CustomMemberColumns extends _HOOK_CLASS_ { /** * Add our own column to default fields */ public function __construct() { static::$databaseIdFields = array_merge( static::$databaseIdFields, array( 'remote_id' ) ); parent::__construct(); } }
  19. Ah you're right. What about with custom columns? My hook is valid since inputting a column that doesn't exist here throws an error, with a valid column it throws the same error as before: static::$databaseIdFields = array_merge( static::$databaseIdFields, array( 'remote_id' ) );
  20. Fresh install, trying to add an API route but Member::load breaks any time I pass $idField, even default fields. works: $member = \IPS\Member::load(1); $member = \IPS\Member::load(1, 'member_id'); Returns { "errorCode": "EX0", "errorMessage": "" } System log says "InvalidArgumentException (0)", viewing the log shows OutOfRangeException from line 115 /app/system/Patterns/ActiveRecord.php Also, the docs need fixing: /** * Add our own column to default fields */ public function __construct() { static::$databaseIdFields = array_merge( static::$databaseIdFields, array( 'remote_id' ) ); } parent::__construct();
  21. On this page: https://invisioncommunity.com/developers/rest-api?endpoint=forums/forums/POSTindex (and any others regarding permissions) I kept getting the following error when sending an object { "errorCode": "EX1364", "errorMessage": "UNKNOWN_ERROR" } It needs to be sent as an array: Also, "an array of group IDs", if you send an array "[3]" it will literally insert that into the DB, it still seems to function but is probably wrong:
  22. Nginx and php-fpm, tested it in Apache and it worked. Edit: I created an API key while using Apache, switched over to Nginx and using that key gives a valid result, but still using "test" as the key fails (and so the AdminCP shows no options to add/edit keys yet). >curl http://localhost/forums/api/core/hello --user a33cb937a4953c72bc4da6e89da39e51: { "communityName": "IPS Community Suite", "communityUrl": "http:\/\/localhost\/forums\/", "ipsVersion": "4.1.6" } >curl http://localhost/forums/api/core/hello --user test: { "errorCode": "3S290\/7", "errorMessage": "INVALID_API_KEY" } @bfarber Should I submit a bug report?
×
×
  • Create New...