• Content count

  • Joined

  • Last visited


About daFish

  • Rank

Contact Methods

Profile Information

  • Gender
  1. Looks pretty good. What happens with spoilered text in emails? Are they removed?
  2. Would it be possible to activate cycling only when there are more content items available than displayable per page? Currently I have setup a maximum of 12 items but only 4 are in the list so it keeps cycling even if there is nothing to change.
  3. +1 for the decision to support PHP 5.3.
  4. I didn't meant to imply that you should remove the factory capability. For example this is supported by the Symfony 2 DIC. So there would be no new object created upon a request but the already instantiated object used. Look at this example: namespace AcmeFoo; use IPSDb; use AcmeFooToolsUtil; use AcmeFooServiceSomethingElse; class Test1 { protected $db; protected $util; public function __construct(Db $db, Util $util) { $this->db = $db; $this->util = $util; } } class Test2 { protected $db; protected $somethingElse; public function __construct(Db $db, SomethingElse $somethingElse) { $this->db = $db; $this->somethingElse = $somethingElse; } } Assuming both test classes are registered in the DIC when we get both from the container, the instance of $db will be the same. No new object is created as the DB is created using a factory method (see http://symfony.com/doc/current/components/dependency_injection/factories.html). And it is also good design to explicitly specify your dependencies. Here are a couple of articles dealing with the pros and cons of DICs: - http://richardmiller.co.uk/2011/05/19/when-dependency-injection-goes-wrong/ - http://stackoverflow.com/questions/6034748/if-singletons-are-bad-then-why-is-a-service-container-good - http://fabien.potencier.org/article/11/what-is-dependency-injection Speaking of my own observation of this I'm using DICs in PHP for about 4 years now. At the beginning I was very sceptical about the whole concept but after working for so long with them I really see the benefits and advantages it brings. You design your classes in a more structured, clean, and useful way. :smile: What I want to propose good code quality. Btw., Mark, I really enjoy this conversation. It gives me a good feeling the developers are open for discussion even if it turns out that the suggestion won't be implemented (which I don't hope for this ;)).
  5. Why would the database class be different than any other class? What if I want to test my code which depends on the database and I have no way of mocking it to have testing in isolation? Having it as a injectable dependency makes mocking it in tests easy. I just want to state that this major version bump is the best opportunity to establish well tested and proven design principles which lead to better and testable code.
  6. Great to get some insights about the new structure. But instead of introducing multitons wouldn't it be more logical to use a dependency injection container and make it available anywhere? It would enhance testability of the code and use cases like this are also well supported. App developers would also benefit from a DIC as they could easily specify which services they need and get a perfectly configured instance from the container instead of wiring all the needed dependencies themselves. There are various lookup ways possible so it depends on the concrete implementation. You can also have a static class map with classes anywhere which could be then registered with the autoloader. Here is an example for PSR-0 compliance: https://github.com/composer/composer/blob/master/src/Composer/Autoload/ClassLoader.php - there are also implementations for class maps and even an generator for autoloading.
  7. Thanks for the answers, Mark. Even if you don't follow PSR-0 completely, having an autoloader is great and useful. I just want to make sure it will be possible for nearly any custom application to register themselves at the autoloader and be available anywhere. Looking forward to more info about the new suite. :)
  8. This sounds quite awesome. But I have some questions you might be able to answer already: Will you make use of third party components for certain parts of the application like Symfony components? Will you follow the PSR-0 standard for autoloading? Will the application be real UTF-8? Will the already available XML-RPC API have more options or changed against another implementation?
  9. Just removing the <img>-code won't work as the whole container will fall apart. I think I'm going with an blank image. Thanks for your help.
  10. Too bad. Ok then, is there a way to not display an image at all? Just the title.
  11. What do I need to do to scale an image? Currently my images are stretched to fit in the boxes. And as a suggestion: Be able to select which attachment/image should be taken when adding new content. That would be much more flexible especially when you feature a already long running topic.
  12. So this is no Facebook Connect-like addition?
  13. But these custom ad zones are only displayable in the forum/content or can these also be displayed at an external page?
  14. Is it even the default logo when we use our own logo?
  15. Thanks for your extensive answer, Brandon. Even if IPS doesn't consider adding ES in the near time, can I assume that the current product would allow me to develop an addon who would offer ES integration?